Gary Guo
Gary Guo
Let's get this merged and leave the additional filtering and improvement for a separate PR.
Ah. I think increasing to 60 minutes should be fine. The other bazel PRs should hopefully reduce the CI time by a bit, and #21645 depends on this one (since...
I looks at a few failing tests, and it appears they are all failing at setting up keymgr? I don't think that's allowed in ROM ext. I'd suggest we remove...
Apparently bazel will send a SIGTERM, wait for a termination grace period and then send SIGKILL. There's `local_termination_grace_seconds` option to tune it, and it's 15 seconds, which should be sufficient...
I think I still want to pursue this, but it's unlikely that this could be merged before the quiet period, so I'll defer this to a later date.
Apparently now building the bitstream does not require opentitanlib, so we can now ask Bazel to find dependencies and do extra filter on top without too much faff.
I tried to add `SocketAddrNetlink` to rustix but it involves an incredible amount of code duplication. Currently there's a copy of `connect`, `bind`, `sendmsg`, `sendto` for every single type of...
For clarification, I am talking about the syscall side. `connect_v4/connect_v6/connect_unix` all just encode the sockaddr and perform a syscall.
Would it make sense to have a `SocketAddr` trait, that just does encode and decode to `sockaddr_*`? ```rust trait SocketAddr { fn encode(&self) -> SocketAddrStorage; fn decode(storage: &SocketAddrStorage) -> Result;...
I plan to do the next point release after `c_unwind` feature stabilisation.