Navneet Verma

Results 321 comments of Navneet Verma

> It looks like this is already publicly exposed on `LatLonShapeDocValues`, which is public itself so I'm not clear why we need this new method? (Also it's awkward to be...

> > Maybe we should make the ctor that takes a `BytesRef` public for such use-cases? > > We can either make the `LatLonShapeDocValues` and `XYShapeDocValues` ctor public, or add...

@nknize can I get a review on this PR, its been open for a long time.

> I would prefer that factory methods that creates `LatLonShapeDocValues` are placed on that class instead of crowding `LatLonShape` with all those methods. Same for XY. I can see functions...

Updated the Code as there were merge conflicts. @jpountz or @iverase can you please review, as I need 1 more reviewer.

> There's no automation for that. Just check out `branch_9x` and cherry-pick the commit and open a backport PR. wasn't aware of that.

Closing the issue as the code is merged. https://github.com/opensearch-project/OpenSearch/pull/4180

Closing this issue. as it is not happening now