Navid C. Constantinou
Navid C. Constantinou
@glwagner would you be keen to review this?
> > @elise-palethorpe also perhaps change the validation script name as @glwagner suggest? > > Do we need the file at all? Can I just include mg preconditioner in `doubly_bounded_poisson.jl`...
@elise-palethorpe, I added some proper bench tests in `doubly_bounded_poisson.jl`. Seems like the PCG `solve!` has many allocations! I don't know why... @glwagner, @simone-silvestri?
I used Julia v1.8 memory allocation profiler and I saw that this https://github.com/CliMA/Oceananigans.jl/blob/a5409c27380a205f27961cc6ce4f24581b98fab8/src/Fields/field.jl#L500 creates a bunch of allocations.
Some benches. ```Julia julia> include("validation/elliptic_solvers/doubly_bounded_poisson.jl") julia> include("doubly_bounded_poisson.jl") [ Info: Solving the Poisson equation with an FFT-based solver... 123.083 μs (93 allocations: 17.56 KiB) [ Info: Solving the Poisson equation with...
ok @glwagner this is ready to review! A question for you: We didn't include `fill_halos!(z)` in the MG-preconditioning: https://github.com/CliMA/Oceananigans.jl/blob/bd0363a54c6f0054cc7a67f5f61e30f12a839bc1/src/Models/HydrostaticFreeSurfaceModels/pcg_implicit_free_surface_solver.jl#L231-L235 Do you think we should have had?
As part of the examples refactor I'm wondering whether we should we also change some of the examples to use a Makie variant for plotting?
A movie was produced! https://github.com/CliMA/OceananigansDocumentation/blob/gh-pages/previews/PR2333/generated/baroclinic_adjustment.mp4
I'm reopening since #2333 didn't really make the building of the docs faster.
“Installation and Getting started” or “Installation and Get going...” ?