About test_criterion

Open wuqun-tju opened this issue 1 year ago • 1 comments

Hello, I wanna know why the sign of MatchingLoss in the test_criterion is negtivate:

Regr3D(L21, norm_mode='?avg_dis', gt_scale=True, sky_loss_value=0) + -1.*MatchingLoss(APLoss(nq='torch', fp=torch.float16), negatives_padding=12288)"

Sep 23 '24 08:09 wuqun-tju

Hi, the comment in the code about the APLoss was wrong, it returns AP, not 1-AP. Since for AP, higher is better, and it is the opposite for Regr3D, it's logical that the loss is Regr3D - AP.

Sep 24 '24 08:09 yocabon