egjs-flicking icon indicating copy to clipboard operation
egjs-flicking copied to clipboard

React Flicking: some combinations of hanger and anchor prevent moving

Open gamtiq opened this issue 4 years ago β€’ 3 comments
trafficstars

Description

Usage of some combinations of hanger & anchor prevents ability to focus panels. Nor flicking's next method neither panel's focus method does work. I've found that the following combinations cause the issue:

  • hanger - "100%", anchor - "100%"
  • hanger - "100%", anchor - "0%" or "0"

Steps to check or reproduce

Use the following code sandbox: https://codesandbox.io/s/react-flicking-hanger-anchor-move-issue-mhxcq Try to click "Focus next" button several times. You will see that panels aren't moved.

gamtiq avatar Nov 30 '20 15:11 gamtiq

Thanks for reporting the issue! I found out that this is a bug in Panel's focus method, which prevents Flicking from moving it.

  • https://github.com/naver/egjs-flicking/blob/master/src/components/Panel.ts#L136

Flicking's next and prev method uses Panel's focus, while moveTo is not. So please use moveTo method instead while I'm fixing this issue :)

WoodNeck avatar Dec 01 '20 07:12 WoodNeck

This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 30 days. It will be closed automatically if no further update occurs in 7 day. Thank you for your contributions!

ν•œκΈ€ 이 이슈/PR은 commits, comments, labels, milestones λ“± 30일간 ν™œλ™μ΄ μ—†μ–΄ μžλ™μœΌλ‘œ stale μƒνƒœλ‘œ μ „ν™˜λ˜μ—ˆμŠ΅λ‹ˆλ‹€. 이후 7일간 ν™œλ™μ΄ μ—†λ‹€λ©΄ μžλ™μœΌλ‘œ λ‹«νž μ˜ˆμ •μž…λ‹ˆλ‹€. ν”„λ‘œμ νŠΈ κ°œμ„ μ— κΈ°μ—¬ν•΄μ£Όμ…”μ„œ κ°μ‚¬ν•©λ‹ˆλ‹€.

stale[bot] avatar Dec 31 '20 20:12 stale[bot]

To prevent auto-closing: the issue still takes place in latest version 3.5.1. See the demo: https://codesandbox.io/s/react-flicking-hanger-anchor-move-issue-mhxcq

gamtiq avatar Jan 02 '21 13:01 gamtiq