egjs-flicking
egjs-flicking copied to clipboard
React Flicking: some combinations of hanger and anchor prevent moving
Description
Usage of some combinations of hanger & anchor prevents ability to focus panels.
Nor flicking's next method neither panel's focus method does work.
I've found that the following combinations cause the issue:
hanger- "100%",anchor- "100%"hanger- "100%",anchor- "0%" or "0"
Steps to check or reproduce
Use the following code sandbox: https://codesandbox.io/s/react-flicking-hanger-anchor-move-issue-mhxcq Try to click "Focus next" button several times. You will see that panels aren't moved.
Thanks for reporting the issue!
I found out that this is a bug in Panel's focus method, which prevents Flicking from moving it.
- https://github.com/naver/egjs-flicking/blob/master/src/components/Panel.ts#L136
Flicking's next and prev method uses Panel's focus, while moveTo is not.
So please use moveTo method instead while I'm fixing this issue :)
This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 30 days. It will be closed automatically if no further update occurs in 7 day. Thank you for your contributions! νκΈ
μ΄ μ΄μ/PRμ commits, comments, labels, milestones λ± 30μΌκ° νλμ΄ μμ΄ μλμΌλ‘ stale μνλ‘ μ νλμμ΅λλ€. μ΄ν 7μΌκ° νλμ΄ μλ€λ©΄ μλμΌλ‘ λ«ν μμ μ
λλ€. νλ‘μ νΈ κ°μ μ κΈ°μ¬ν΄μ£Όμ
μ κ°μ¬ν©λλ€.
To prevent auto-closing: the issue still takes place in latest version 3.5.1. See the demo: https://codesandbox.io/s/react-flicking-hanger-anchor-move-issue-mhxcq