Navaron Bracke

Results 472 comments of Navaron Bracke

Could you provide a minimal reproducible sample? This seems like not something `play-services-mlkit-barcode-scanning` would do?

@Widcket Apologies, I had an issue during the interactive rebase when trying to fix the commit signing, so I had to start over. I also applied your comments from the...

I don't understand why the Sentry report might still be reporting the getter as uncovered? The `Auth0FlutterWebPlatform` class in which it is defined is `abstract`, so cannot be instantiated. The...

It seems that the upstream iOS & MacOS tests are broken currently? This prevents new test reports from being made.

@Widcket Code coverage should be fine now. PTAL.

@Widcket I had a look at the failing tests: The failing iOS tests seem to be due to CI using XCode 15.0.1 ? When I open the relevant code that...

Maybe we should update to the latest hotfix version for XCode 15, which is XCode 15.4? Maybe the fix for that problem is in one of the hotfixes for XCode...

Well, now there is a different issue for iOS: ``` /Users/runner/work/auth0-flutter/auth0-flutter/auth0_flutter/example/ios/Pods/Auth0/Auth0/ASProvider.swift:70:47: error: cannot assign value of type 'ASUserAgent' to type '(any ASWebAuthenticationPresentationContextProviding)?' session.presentationContextProvider = self ^~~~ /Users/runner/work/auth0-flutter/auth0-flutter/auth0_flutter/example/ios/Pods/Auth0/Auth0/ASProvider.swift:70:47: note: add missing...

The native iOS unit tests seem to pass on your PR for the Ruby version? Interesting, maybe there is indeed a caching issue in Github Actions.

Since we now have WASM support, I am in the process of updating the web specific mocking for the tests.