nautobot icon indicating copy to clipboard operation
nautobot copied to clipboard

Ensures active_tab is in context of all views

Open whitej6 opened this issue 1 year ago • 2 comments

Closes: #4986

What's Changed

Initial pass on ensuring active_tab is set for all views that overload get_extra_context

TODO

  • [ ] Explanation of Change(s)
  • [ ] Added change log fragment(s) (for more information see the documentation)
  • [ ] Attached Screenshots, Payload Example
  • [ ] Unit, Integration Tests
  • [ ] Documentation Updates (when adding/changing features)
  • [ ] Example Plugin Updates (when adding/changing features)
  • [ ] Outline Remaining Work, Constraints from Design

whitej6 avatar Dec 14 '23 19:12 whitej6

Does this handle hardcoded items like this? https://github.com/nautobot/nautobot/blob/15d9d9f04f8a420b8c6cf179955ad098bf2b61dc/nautobot/dcim/views.py#L1155

joewesch avatar Dec 21 '23 17:12 joewesch

Does this handle hardcoded items like this?

https://github.com/nautobot/nautobot/blob/15d9d9f04f8a420b8c6cf179955ad098bf2b61dc/nautobot/dcim/views.py#L1155

Yes, the super was only added when active tab was not provided

whitej6 avatar Dec 23 '23 22:12 whitej6