nautobot-app-nornir icon indicating copy to clipboard operation
nautobot-app-nornir copied to clipboard

Renaming work

Open whitej6 opened this issue 1 year ago • 7 comments

whitej6 avatar Dec 26 '23 19:12 whitej6

ok, I see now that it was worded as:

Nautobot Plugin Nornir is the only app that has plugin in the package name and will keep it's python package named nautobot_plugin_nornir

It wasn't clear that anything else was changing, need to think about this one.

itdependsnetworks avatar Dec 29 '23 19:12 itdependsnetworks

ok, I see now that it was worded as:

Nautobot Plugin Nornir is the only app that has plugin in the package name and will keep it's python package named nautobot_plugin_nornir

It wasn't clear that anything else was changing, need to think about this one.

Yeah I'd like to figure out long term to fully rename without causing breaking changes.

whitej6 avatar Dec 29 '23 23:12 whitej6

Starting to feel like this will cause a lot of confusion if we don't do the project rename and the package rename at the same time. Gets confusing when reviewing the GC project rename and starting to keep straight the project names, the plugin_config section and what that should be named etc.

jeffkala avatar Jan 02 '24 17:01 jeffkala

Yea, I am not sure about this, I think we need to change everything and have a proper rollout plan if we are going to go to this.

itdependsnetworks avatar Jan 02 '24 17:01 itdependsnetworks

In talking with Jeff, will certainly have to think about this, so please remove this from the Jan 9th deadline. One potential migration plan would be

  • symlink the folder from app -> plugin
  • Allow either to be installed
  • Publish to pypi on both names
  • Once Nautobot Core goes to 3.0, we remove all reference to plugin.

This may allow us to support both app and plugin names for the time being.

itdependsnetworks avatar Jan 02 '24 17:01 itdependsnetworks

In talking with Jeff, will certainly have to think about this, so please remove this from the Jan 9th deadline. One potential migration plan would be

  • symlink the folder from app -> plugin
  • Allow either to be installed
  • Publish to pypi on both names
  • Once Nautobot Core goes to 3.0, we remove all reference to plugin.

This may allow us to support both app and plugin names for the time being.

Unfortunately I don't think the symlink would work due to import for the config has the match the config.name configured here

whitej6 avatar Jan 02 '24 17:01 whitej6

Good point... will have to think about that.

itdependsnetworks avatar Jan 02 '24 17:01 itdependsnetworks