nautobot-app-golden-config icon indicating copy to clipboard operation
nautobot-app-golden-config copied to clipboard

Delete All config compliance objects doesn't work

Open matt852 opened this issue 1 year ago • 6 comments

Environment

  • Python version: 3.8.6
  • Nautobot version: 1.3.7
  • nautobot-golden-config version: 1.0.3

Steps to Reproduce

  1. Generate 26+ configuration compliance entries in the "Configuration Compliance" page/table
  2. Change your table view to be 25 items at a time
  3. Hit the check box to select all items on the page
  4. In the new selection that appears, select "Select all ### config compliances matching query"
  5. Click the "Delete All" button

Expected Behavior

The confirmation page prompting me to delete all entries should appear. Note: This works when selecting multiple entries on a single page.

Observed Behavior

The below warning banner appears, and the page refreshes, without prompting me to confirm object deletion:

"No config compliances were selected for deletion."

matt852 avatar Aug 10 '22 20:08 matt852

It should also be noted that this is limited to the "Delete All" button. Selecting <1000 items, and selecting "Delete" at the bottom of the page, will work as expected as long as all items are on the same visible page.

matt852 avatar Aug 10 '22 20:08 matt852

Is this different than nautobot? If not, likely to fall into “works as expected”

itdependsnetworks avatar Aug 10 '22 20:08 itdependsnetworks

@itdependsnetworks This works correctly on other core Nautobot pages, such as "Devices"

matt852 avatar Aug 11 '22 15:08 matt852

Are you saying this doesn't show up? like this:

image

itdependsnetworks avatar Aug 20 '22 13:08 itdependsnetworks

Not quite. On the plug-in, the button shows up. But when you click on it, the page refreshes and nothing happens.

On other core Nautobot pages, it loads an "Are you sure?" page.

Are the above replication steps not working correctly?

matt852 avatar Aug 20 '22 15:08 matt852

@jeffkala to take a look at recreating in his env

itdependsnetworks avatar Sep 07 '22 13:09 itdependsnetworks

Can duplicate on demo.nautobot.com, it actually pops up with delete all 389 objects, you click the button and the next plage actually only loads the first object and says are you sure, folowed by not deleting it at all.

jeffkala avatar Sep 23 '22 02:09 jeffkala

@matt852 what would you expect for this? To just have it reload back to having now "last" dates? This view is actually populated based on the device list. An actual object isn't even created until a backup/intended etc has been run on that device.

jeffkala avatar Sep 23 '22 16:09 jeffkala

Fixed in #353

itdependsnetworks avatar Sep 27 '22 01:09 itdependsnetworks