nautobot-app-device-lifecycle-mgmt icon indicating copy to clipboard operation
nautobot-app-device-lifecycle-mgmt copied to clipboard

Moves all Validated Software assigned items to tabs

Open joewesch opened this issue 8 months ago • 3 comments

Closes: #441

What's Changed

This PR changes the Validated Software detail view to move the lists of assigned items to separate tabs.

Before

Screenshot 2025-04-01 at 2 47 13 PM Screenshot 2025-04-01 at 2 47 17 PM Screenshot 2025-04-01 at 2 47 23 PM

After

Main tab

Screenshot 2025-04-01 at 3 35 17 PM

Individual tabs

Screenshot 2025-04-01 at 3 35 27 PM Screenshot 2025-04-01 at 3 35 33 PM Screenshot 2025-04-01 at 3 35 38 PM Screenshot 2025-04-01 at 3 35 44 PM Screenshot 2025-04-01 at 3 35 49 PM

To Do

  • [x] Explanation of Change(s)
  • [x] Added change log fragment(s) (for more information see the documentation)
  • [x] Attached Screenshots, Payload Example
  • [ ] Unit, Integration Tests
  • [ ] Documentation Updates (when adding/changing features)
  • [ ] Outline Remaining Work, Constraints from Design

joewesch avatar Apr 01 '25 20:04 joewesch

does it make sense to use nautobot.core.ui.object_detail.ObjectsTablePanel here?

Here is an example of it in use: https://github.com/nautobot/nautobot/pull/6962/files#diff-caf8a412a9f30295cacfae888c0fbc1bdc2a7cd2643df55f444414f363113a7bR1392-R1398

it already paginates and handles a bunch more.

itdependsnetworks avatar Apr 01 '25 21:04 itdependsnetworks

I'm open to changing it, I was just moving what already existed for performance reasons. I do feel like that's a lot of screen real estate with so many tables on the right side of the page, so maybe a combination of the new tab along with the ObjectsTablePanel?

Thoughts @progala?

joewesch avatar Apr 02 '25 12:04 joewesch

nautobot.core.ui.object_detail.ObjectsTablePanel requires Nautobot 2.4.0+ . DLM 3.0.0 supports 2.2.0+, and I don't think we're going to move straight to Nautobot 2.4.0+ in DLM 3.1.0.

progala avatar Apr 09 '25 14:04 progala