nautobot-app-bgp-models icon indicating copy to clipboard operation
nautobot-app-bgp-models copied to clipboard

Re-evaluate uniqueness of ASN number

Open Kircheneer opened this issue 2 years ago • 4 comments

Environment

  • Nautobot version: 1.5.4
  • nautobot-bgp-models version: 0.7.0-beta.1

Proposed Functionality

Remove the unique=True parameter to the ASNField on the ASN model.

Use Case

Re-use of private ASNs between either different locations of the same tenant or possibly between different tenants altogether.

Kircheneer avatar Dec 09 '22 08:12 Kircheneer

Considerations:

  • Validate that two distinct instances of equal-numbered ASNs can't peer?
  • How does this affect form rendering?
  • How does this affect GraphQL responses?

Kircheneer avatar Dec 15 '22 13:12 Kircheneer

Could be implemented by adding

  • tenant
  • location

fields on the model, dropping the uniqueness constraint on the asn field and adding a new one for the combination of location/tenant/asn.

Kircheneer avatar Dec 15 '22 13:12 Kircheneer

Validate that two distinct instances of ASNs can't peer?

If this is current state, I would think it was incorrect, if this is future state, I am not understanding why this would be helpful?

itdependsnetworks avatar Dec 15 '22 15:12 itdependsnetworks

Validate that two distinct instances of ASNs can't peer?

If this is current state, I would think it was incorrect, if this is future state, I am not understanding why this would be helpful?

Good catch - I added the little word "equal-numbered"

Kircheneer avatar Dec 15 '22 16:12 Kircheneer