nautilus_trader icon indicating copy to clipboard operation
nautilus_trader copied to clipboard

Add maker_fee and taker_fee params to FuturesContract and OptionsContract __init__()

Open naught2020 opened this issue 1 year ago • 4 comments

Bug Report

maker_fee and taker_fee arguments are missing in instruments init method, FuturesContract and OptionContract fee is always default value Decimal(0).

naught2020 avatar Jun 17 '24 06:06 naught2020

Thanks for the report @naught2020

One reason this is missing is because we have plans for moving fee and margin related fields off instruments and into FeeModel and the venue config.

We're currently still deciding if it makes sense to add these params for consistency and accept the overhead of wiring this all throughout the platform into Rust - or, proceed with the above refactoring instead.

I'll change this ticket over to an enhancement request as this is a known limitation and not a bug as such.

cjdsellers avatar Jun 20 '24 06:06 cjdsellers

hi! i would like to know if there is any progress about this enhancement?

stentor2018 avatar Aug 16 '24 00:08 stentor2018

Hi @stentor2018

This is actually blocked right now pending a refactoring of fee modeling.

We didn't want to spend time adding these parameters everywhere (which takes significant time including through Rust), when we're moving to decoupling this from the instrument definitions.

Thanks for your patience 🙏.

cjdsellers avatar Aug 17 '24 23:08 cjdsellers

got it, thanks for your reply! I will keep waiting.

naught2020 avatar Aug 18 '24 04:08 naught2020

Isn't this already solved in latest release 1.208.0 Beta?

Image

stefansimik avatar Dec 15 '24 22:12 stefansimik

Thanks @stefansimik

This one can be closed as completed.

cjdsellers avatar Dec 15 '24 22:12 cjdsellers