nat
nat copied to clipboard
Fix/matching by col numeric
- Fixes #503
- but we still need to sort out numeric ids like 1e5, since:
> as.character(1e5)
[1] "1e+05"
Codecov Report
Merging #504 (2b36409) into master (49d578d) will increase coverage by
1.14%
. The diff coverage is70.00%
.
@@ Coverage Diff @@
## master #504 +/- ##
==========================================
+ Coverage 75.73% 76.88% +1.14%
==========================================
Files 48 48
Lines 5906 5914 +8
==========================================
+ Hits 4473 4547 +74
+ Misses 1433 1367 -66
Impacted Files | Coverage Δ | |
---|---|---|
R/neuronlist.R | 80.86% <70.00%> (-0.44%) |
:arrow_down: |
R/neuron-io.R | 84.71% <0.00%> (+1.55%) |
:arrow_up: |
R/amiralandmarks-io.R | 90.74% <0.00%> (+9.25%) |
:arrow_up: |
R/neuronlistfh.R | 79.47% <0.00%> (+30.52%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Doesn't as.character(bit64::as.integer64((x)))
solve the problem?
Doesn't as.character(bit64::as.integer64((x))) solve the problem? @dokato yes some variation on that could help, but I have so far resisted to make base nat depend on the bit64 package.