natureofcode.com icon indicating copy to clipboard operation
natureofcode.com copied to clipboard

Published 20 hours ago • verified publisher icon nature-of-code

Change colour of links to pass the WCAG contrast ratio guidelines and…

Open wormmoon opened this issue 5 years ago • 3 comments

… make them readable

Current colour #30def6 has a low contrast ratio with the background colour #f6f6f6 and may be unreadable for some people. Does not pass test on https://contrast-ratio.com/. New colour #237480 does pass this test.

wormmoon avatar Sep 21 '18 13:09 wormmoon

Thank you so much for this! ❤️❤️❤️

I'm working with some collaborators at ITP to make the materials more WCAG compliant and this is super helpful. A couple quick comments:

  1. If possible, can you include a screenshot illustrating the difference (this is helpful when reviewing pull requests!)
  2. Ultimately, this change will need to be made in The Nature of Code book source repo as this is what generates the html/css/etc files that I transfer over here when updating the book content.

shiffman avatar Sep 22 '18 13:09 shiffman

Thank you so much for this! ❤️❤️❤️

I'm working with some collaborators at ITP to make the materials more WCAG compliant and this is super helpful. A couple quick comments:

  1. If possible, can you include a screenshot illustrating the difference (this is helpful when reviewing pull requests!)
  2. Ultimately, this change will need to be made in The Nature of Code book source repo as this is what generates the html/css/etc files that I transfer over here when updating the book content.

Ahh thank /you/ for this book!

Okay I will do this today!

wormmoon avatar Sep 25 '18 12:09 wormmoon

Apologies that this was never addressed! I am working on a new design that I would will be more accessible at https://github.com/nature-of-code/book-website-2nd-edition

shiffman avatar Nov 03 '22 13:11 shiffman