homebrewery icon indicating copy to clipboard operation
homebrewery copied to clipboard

[FEATURE]: Save Brew to Image

Open G-Ambatte opened this issue 2 years ago • 7 comments

The Region Capture feature of Chrome (Desktop v104 and up) allows a MediaStream to be cropped to a target element. It should be possible to use this to capture the browser's rendered output to either the clipboard (blob) or to a file (PNG).

This article has details about the feature.


This paragraph mentions a potential future Element-level Capture API, which seems like it would be exactly what is needed for this functionality.

G-Ambatte avatar Aug 14 '22 00:08 G-Ambatte

Genuine doubt, what would be the difference between this and exporting a pdf and transforming that into a jpeg or png?

And between those two and Window's Snipping tool?

5e-Cleric avatar Aug 20 '22 21:08 5e-Cleric

Answering myself from the future: absolutely no difference.

5e-Cleric avatar Feb 04 '23 16:02 5e-Cleric

what would be the difference between this and exporting a pdf and transforming that into a jpeg or png?

User convenience: ideally a one click process resulting in a high resolution image of the full content.

And between those two and Window's Snipping tool?

Snipping Tool can result in lower resolution images, and while it is less complex than generating a PDF and converting that to an image, it is still a more complex process than direct image generation.

G-Ambatte avatar Jun 14 '23 22:06 G-Ambatte

I have a working draft for this issue not based on the chrome region grabbing but it has a few issues likely relating to CORS that I have not yet worked out, thus DRAFT. https://github.com/naturalcrit/homebrewery/pull/3219

dbolack-ab avatar Jan 17 '24 01:01 dbolack-ab

@dbolack-ab i believe this issue refers to making the ENTIRE BREW to an image, not just 1 page.

5e-Cleric avatar Jan 17 '24 11:01 5e-Cleric

@dbolack-ab i believe this issue refers to making the ENTIRE BREW to an image, not just 1 page.

you would still do it page by page (capturing the page element).

Gazook89 avatar Jan 17 '24 18:01 Gazook89

@dbolack-ab i believe this issue refers to making the ENTIRE BREW to an image, not just 1 page.

you would still do it page by page (capturing the page element).

Why would you do that? To make a CBR?

dbolack-ab avatar Jan 30 '24 02:01 dbolack-ab