homebrewery
homebrewery copied to clipboard
[WIP] Account Page
On completion, this PR resolves #2043.
Adds a new page /account
which displays user information from the JWT token.
Images from current state of the PR:
Account menu:
Account Info page:
Attempts to implement Google permissions checking.
Signed into Homebrewery only:
Signed into Homebrewery only but account IS linked to Google:
Signed into Google but no permissions granted:
Signed into Google with permissions granted:
Added a little styling to the info panel.
-
I think we might need to agree on exactly what information we want to display here, and ensure it is all as clear as possible to the users what it means. For instance. "Google auth check" probably means nothing to most users, but "Google drive accessible" might be more obvious? Actually, there's probably still a better way to say that.
-
(Also, we might want to fancy up the styling a bit more with some icons and a less "spreadsheet" feel with the table styling. Make is as un-intimidating and not-confusing as possible. @Gazook89 might have some ideas.)
Eventually this page might be where we place password management, account deletion, etc., so even if we keep the PHB style, it might benefit from some obvious "Homebrewery" interface icons, much like we do in the user brews page with the black button panels and icons everywhere, etc.
- We probably should make this its own React component "page" like
userpage.jsx
oreditpage.jsx
instead of constructing a brew document. Gives us some more freedom to place components around and keeps theapp.js
clean.
- The PR started out as "what account information can be displayed that might be useful for troubleshooting" and grew from there; there is probably a considerable amount that can be added to clarify what each item is for the uninitiated.
- Styling was originally kept as minimal as possible for brevity.
- This needs to become it's own
/pages/account
page, which will probably link in to thebasePages/uiPage
PR.
It's currently on the back burner for me at the moment, but I think there's a reasonably clear direction to progress this PR once I can pick it back up again.
- Ok, let's stick with what you already have, and just work on naming them in the most "user-friendly" way so it's obvious what users are looking at. We can add more info later.
- That's fine. I just don't want it to be confused with "a brew". We can probably borrow some styling from the User Page just to make it slightly more "Hombrewery UI".
- Thumbs up.
I'll review in ~4-5 hrs
Is it intended that the account page doesn't have the help
and new brew
nav items?
Superseded by #2161