homebrewery icon indicating copy to clipboard operation
homebrewery copied to clipboard

[WIP] Account Page

Open G-Ambatte opened this issue 2 years ago • 7 comments

On completion, this PR resolves #2043.

Adds a new page /account which displays user information from the JWT token.

Images from current state of the PR:

Account menu: image

Account Info page: image

image

image

G-Ambatte avatar Mar 02 '22 02:03 G-Ambatte

Attempts to implement Google permissions checking.

Signed into Homebrewery only: image

Signed into Homebrewery only but account IS linked to Google: image

Signed into Google but no permissions granted: image

Signed into Google with permissions granted: image

G-Ambatte avatar Mar 02 '22 05:03 G-Ambatte

Added a little styling to the info panel.

image

G-Ambatte avatar Mar 02 '22 10:03 G-Ambatte

  1. I think we might need to agree on exactly what information we want to display here, and ensure it is all as clear as possible to the users what it means. For instance. "Google auth check" probably means nothing to most users, but "Google drive accessible" might be more obvious? Actually, there's probably still a better way to say that.

  2. (Also, we might want to fancy up the styling a bit more with some icons and a less "spreadsheet" feel with the table styling. Make is as un-intimidating and not-confusing as possible. @Gazook89 might have some ideas.)

Eventually this page might be where we place password management, account deletion, etc., so even if we keep the PHB style, it might benefit from some obvious "Homebrewery" interface icons, much like we do in the user brews page with the black button panels and icons everywhere, etc.

image

  1. We probably should make this its own React component "page" like userpage.jsx or editpage.jsx instead of constructing a brew document. Gives us some more freedom to place components around and keeps the app.js clean.

calculuschild avatar Mar 27 '22 05:03 calculuschild

  1. The PR started out as "what account information can be displayed that might be useful for troubleshooting" and grew from there; there is probably a considerable amount that can be added to clarify what each item is for the uninitiated.
  2. Styling was originally kept as minimal as possible for brevity.
  3. This needs to become it's own /pages/account page, which will probably link in to the basePages/uiPage PR.

It's currently on the back burner for me at the moment, but I think there's a reasonably clear direction to progress this PR once I can pick it back up again.

G-Ambatte avatar Mar 27 '22 20:03 G-Ambatte

  1. Ok, let's stick with what you already have, and just work on naming them in the most "user-friendly" way so it's obvious what users are looking at. We can add more info later.
  2. That's fine. I just don't want it to be confused with "a brew". We can probably borrow some styling from the User Page just to make it slightly more "Hombrewery UI".
  3. Thumbs up.

calculuschild avatar Apr 13 '22 03:04 calculuschild

I'll review in ~4-5 hrs

jeddai avatar Apr 29 '22 21:04 jeddai

Is it intended that the account page doesn't have the help and new brew nav items?

jeddai avatar Apr 30 '22 01:04 jeddai

Superseded by #2161

calculuschild avatar Oct 30 '22 15:10 calculuschild