homebrewery
homebrewery copied to clipboard
naturalcrit
Brew Renderer and Editor divider is not based on percentage of the screen
Description
This is a minor UI issue.
When changing the divider's position, it saves its position as a px value, not as % value.
On one of my PCs, I'm using two monitors: one is 1366x768, the other one is 1920x1080. In the 1920x1080 monitor, I setted the divider roughly on the middle of the screen. When changing the tab back to the 1366x768 monitor, the editor occupies roughly 70% of the screen.
Here are some screenshots to make it clear:
1920x1080 screen:
1366x768 screen:
I guess it depends what behavior is most desirable. I could argue that the current behavior preserves the editor size so switching between monitors does not change line positions, etc., which might be preferable.
A new reddit issue just came in that made me think of this issue: https://old.reddit.com/r/homebrewery/comments/sqv50q/issue_preview_pane_is_missing/
User can't see the preview pane, only the text editor. Likely because the divider is all the way to the right. fortunately, they should be able to just expand their browser window to reveal the divider, and then slide it back to the left.
If the divider was positioned as a percentage (100%), this might not be possible. But as a pixel amount, it is.
To be fair, though, a max % could be set so this never happens.
To be fair, though, a max % could be set so this never happens.
Or a menu option to change the position - 0% (BrewRender only), 50% (normal), 100% (Editor only).
@calculuschild Do you think we can close this one as well, based on the merging of #2055?
I've just tested this in the same PC where I faced the issue, and the screen division keeps the % instead of the px, so I'm closing this one.