stan.java icon indicating copy to clipboard operation
stan.java copied to clipboard

Published 20 hours ago • verified publisher icon nats-io

inflight counting fixes

Open tul opened this issue 7 years ago • 4 comments

Proposed fixes for issue #79

tul avatar Jan 25 '18 15:01 tul

Coverage Status

Coverage decreased (-1.6%) to 91.324% when pulling 6dc800179b0de5facdc338c3c7b4e8e107a464b7 on mctully:lkwd_dev into 718bc8811439bb19fc9849f95faa0068acbd30b3 on nats-io:master.

coveralls avatar Jan 25 '18 15:01 coveralls

The code has chance significantly apparently, how would you like to proceed on this change?

sasbury avatar Aug 22 '18 18:08 sasbury

Sorry, I haven’t yet looked at the new client lib release. When we move to the new library I will re-test for the original issue. If it still occurs then I’ll see whether I can update this patch. Thanks!

tul avatar Aug 22 '18 21:08 tul

FWIW, I’ve just looked over the sources on master and I don’t think the areas I patched have changed significantly. I can see that publish() will still block indefinitely if max acks is hit, so I assume the original issue is still possible if you get in a state where acks are not popped.

tul avatar Aug 22 '18 21:08 tul