nats.go icon indicating copy to clipboard operation
nats.go copied to clipboard

Published 20 hours ago • verified publisher icon nats-io

object store add link changes and some refactoring

Open scottf opened this issue 2 years ago • 2 comments

scottf avatar Jan 14 '22 20:01 scottf

Coverage Status

Coverage decreased (-0.2%) to 85.632% when pulling 5caf13221c60bb9445625bbeececdc24b5da06e2 on os-link-change-sff into b81c9e71b4795229aa01cbe977c555b3affa6d9f on main.

coveralls avatar Jan 16 '22 20:01 coveralls

@kozlovic This fell off my radar b/c of other priorities. There were some questions that we had not gotten around to being resolved and there was never an approval and that's why it never got merged.

scottf avatar May 19 '22 13:05 scottf

Open Questions

  1. Should we allow links to links?
  2. Should we return ErrObjectNotFound for Get/GetInfo when an object is deleted? This would match what KV does on get where the entry is deleted. This would also affect links to things that were linked then deleted.
  3. Why are we keeping the meta information around for a deleted object anyway? Is it strictly for watch? Should we possibly add a Purge Deletes, this would also match KV.
  4. when an object is Put, info.ModTime is set to the client time at the end of the work. This is a client time, not the actual server message time. When machines clocks are in sync, this is probably a few milliseconds at most. We could ask the server for the message to get the actual time, but this would require an additional call to the server. Do we care one way or the other.

scottf avatar Aug 20 '22 22:08 scottf