nats.c icon indicating copy to clipboard operation
nats.c copied to clipboard

[CI only] Skip codecov for forks until they resolve tokenless uploads…

Open levb opened this issue 1 year ago • 3 comments

https://github.com/nats-io/nats.c/pull/763 is currently failing to upload codecov reports, because of an issue in codecov. Until they resolve it, disable codecov for PRs from forked repos.

levb avatar Jun 21 '24 18:06 levb

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.71%. Comparing base (1553d4a) to head (311b54a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #768   +/-   ##
=======================================
  Coverage   68.71%   68.71%           
=======================================
  Files          39       39           
  Lines       15207    15207           
  Branches     3143     3143           
=======================================
  Hits        10449    10449           
- Misses       1700     1701    +1     
+ Partials     3058     3057    -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 21 '24 18:06 codecov[bot]

No I don't have a way of testing this, short of maybe you cutting a PR to my fork from your fork. This PR itself is the test that it still fires on our repo.

levb avatar Jun 22 '24 12:06 levb

@levb I don't use forks, that's why I asked if the PR that demonstrated this issue (PR #763) could not add this one line fix to see if that solves the issue.

kozlovic avatar Jun 27 '24 18:06 kozlovic