deadcode analysis 2023-12-12

[philpennock]

Observed behavior

The Go maintainers have released a new tool, deadcode: https://go.dev/blog/deadcode

This is a "zero false negatives" (as long as in Go and without linker symbol aliasing) approach, and when invoked with the -test flag effectively reports which functions are not covered by any tests.

Expected behavior

Everything covered by tests, or used, so no deadcode function reports.

Server and client version

nats-server repo checkout at commit 1342aa1371b81f0bfa0f324b42b4b85cbfe759fd

Host environment

No response

Steps to reproduce

Run: deadcode -test ./...

NB: the ./... is important, there are a lot more results if you just use .

internal/ldap/dn.go:49:6: unreachable func: FromCertSubject
logger/log.go:50:17: unreachable func: LogUTC.isLoggerOption
logger/syslog.go:37:6: unreachable func: SetSyslogName
server/jetstream_errors_generated.go:665:6: unreachable func: NewJSClusterIncompleteError
server/jetstream_errors_generated.go:963:6: unreachable func: NewJSConsumerEphemeralWithDurableInSubjectError
server/jetstream_errors_generated.go:1003:6: unreachable func: NewJSConsumerFilterNotSubsetError
server/jetstream_errors_generated.go:1245:6: unreachable func: NewJSConsumerOnMappedError
server/jetstream_errors_generated.go:1265:6: unreachable func: NewJSConsumerPullNotDurableError
server/jetstream_errors_generated.go:1547:6: unreachable func: NewJSMirrorWithStartSeqAndTimeError
server/jetstream_errors_generated.go:1557:6: unreachable func: NewJSMirrorWithSubjectFiltersError
server/jetstream_errors_generated.go:1917:6: unreachable func: NewJSStreamInfoMaxSubjectsError
server/jetstream_errors_generated.go:2173:6: unreachable func: NewJSStreamReplicasNotUpdatableError
server/jetstream_errors_generated.go:2225:6: unreachable func: NewJSStreamSequenceNotMatchError
server/jetstream_test.go:19505:6: unreachable func: SingleFilterConsumerCheck
server/jwt.go:32:6: unreachable func: ReadOperatorJWT
server/signal.go:33:6: unreachable func: SetProcessName
test/test.go:51:6: unreachable func: RunDefaultServer
test/test.go:55:6: unreachable func: RunRandClientPortServer