rename copy to other with param …

[dtest11]

trafficstars

1. the keyword copy is builtin func ,rename copy to other with param as prefix
2. fix some func note

/cc @nats-io/core

[dtest11]

https://travis-ci.com/github/nats-io/nats-server/jobs/516071189 stack trace

=== RUN   TestJetStreamClusterCreateConcurrentDurableConsumers
==================
WARNING: DATA RACE
Write at 0x00c00d0d0410 by goroutine 535:
  github.com/nats-io/nats-server/server.(*Server).shutdownJetStream()
      /home/travis/gopath/src/github.com/nats-io/nats-server/server/jetstream.go:737 +0x56f
  github.com/nats-io/nats-server/server.(*Server).Shutdown()
      /home/travis/gopath/src/github.com/nats-io/nats-server/server/server.go:1747 +0x219
  github.com/nats-io/nats-server/server.(*cluster).shutdown()
      /home/travis/gopath/src/github.com/nats-io/nats-server/server/test_test.go:198 +0xd8
  github.com/nats-io/nats-server/server.TestJetStreamClusterCreateConcurrentDurableConsumers()
      /home/travis/gopath/src/github.com/nats-io/nats-server/server/jetstream_cluster_test.go:6938 +0x715
  testing.tRunner()
      /home/travis/.gimme/versions/go1.16.5.linux.amd64/src/testing/testing.go:1193 +0x202
Previous read at 0x00c00d0d0410 by goroutine 193:
  github.com/nats-io/nats-server/server.(*Server).jsConsumerInfoRequest()
      /home/travis/gopath/src/github.com/nats-io/nats-server/server/jetstream_api.go:3404 +0x153a
  github.com/nats-io/nats-server/server.(*Server).jsConsumerInfoRequest-fm()
      /home/travis/gopath/src/github.com/nats-io/nats-server/server/jetstream_api.go:3333 +0xc4
  github.com/nats-io/nats-server/server.(*jetStream).apiDispatch.func1()
      /home/travis/gopath/src/github.com/nats-io/nats-server/server/jetstream_api.go:666 +0xba
Goroutine 535 (running) created at:
  testing.(*T).Run()
      /home/travis/.gimme/versions/go1.16.5.linux.amd64/src/testing/testing.go:1238 +0x5d7
  testing.runTests.func1()
      /home/travis/.gimme/versions/go1.16.5.linux.amd64/src/testing/testing.go:1511 +0xa6
  testing.tRunner()
      /home/travis/.gimme/versions/go1.16.5.linux.amd64/src/testing/testing.go:1193 +0x202
  testing.runTests()
      /home/travis/.gimme/versions/go1.16.5.linux.amd64/src/testing/testing.go:1509 +0x612
  testing.(*M).Run()
      /home/travis/.gimme/versions/go1.16.5.linux.amd64/src/testing/testing.go:1417 +0x3b3
  github.com/nats-io/nats-server/server.TestMain()
      /home/travis/gopath/src/github.com/nats-io/nats-server/server/sublist_test.go:1448 +0x384
  main.main()
      _testmain.go:2629 +0x271
Goroutine 193 (finished) created at:
  github.com/nats-io/nats-server/server.(*jetStream).apiDispatch()
      /home/travis/gopath/src/github.com/nats-io/nats-server/server/jetstream_api.go:665 +0x624
  github.com/nats-io/nats-server/server.(*jetStream).apiDispatch-fm()
      /home/travis/gopath/src/github.com/nats-io/nats-server/server/jetstream_api.go:609 +0xc4
  github.com/nats-io/nats-server/server.(*client).deliverMsg()
      /home/travis/gopath/src/github.com/nats-io/nats-server/server/client.go:3074 +0x507
  github.com/nats-io/nats-server/server.(*client).processMsgResults()
      /home/travis/gopath/src/github.com/nats-io/nats-server/server/client.go:4049 +0x864
  github.com/nats-io/nats-server/server.(*client).processInboundRoutedMsg()
      /home/travis/gopath/src/github.com/nats-io/nats-server/server/route.go:443 +0x328
  github.com/nats-io/nats-server/server.(*client).processInboundMsg()
      /home/travis/gopath/src/github.com/nats-io/nats-server/server/client.go:3390 +0x95
  github.com/nats-io/nats-server/server.(*client).parse()
      /home/travis/gopath/src/github.com/nats-io/nats-server/server/parser.go:477 +0x3f44
  github.com/nats-io/nats-server/server.(*client).readLoop()
      /home/travis/gopath/src/github.com/nats-io/nats-server/server/client.go:1160 +0x844
  github.com/nats-io/nats-server/server.(*Server).createRoute.func1()
      /home/travis/gopath/src/github.com/nats-io/nats-server/server/route.go:1374 +0x52
==================
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x78 pc=0xb7c44a]
goroutine 56268 [running]:
github.com/nats-io/nats-server/server.(*Server).jsConsumerInfoRequest(0xc01bacd400, 0xc016351380, 0xc0099bf980, 0xc0095c17d0, 0x23, 0xc01cc70fd8, 0x11, 0xc0080e7ba0, 0xd0, 0xd0)
	/home/travis/gopath/src/github.com/nats-io/nats-server/server/jetstream_api.go:3404 +0x154a
github.com/nats-io/nats-server/server.(*jetStream).apiDispatch.func1(0xc0171b46c0, 0xc016351380, 0xc0099bf980, 0xc0095c17d0, 0x23, 0xc01cc70fd8, 0x11, 0xc0080e7ba0, 0xd0, 0xd0, ...)
	/home/travis/gopath/src/github.com/nats-io/nats-server/server/jetstream_api.go:666 +0xbb
created by github.com/nats-io/nats-server/server.(*jetStream).apiDispatch
	/home/travis/gopath/src/github.com/nats-io/nats-server/server/jetstream_api.go:665 +0x625
FAIL	github.com/nats-io/nats-server/server	267.587s
=== RUN   TestPSEmulation
--- PASS: TestPSEmulation (0.01s)
PASS
ok  	github.com/nats-io/nats-server/server/pse	0.031s
?   	github.com/nats-io/nats-server/server/sysmem	[no test files]

[dtest11]

TestJetStreamClusterCreateConcurrentDurableConsumers

that other pr, stack trace

[dtest11]

/cc @nats-io/core. the CI DONT show which test not passed, can help my check ? thanks

[derekcollison]

Will take a look.

[derekcollison]

Apologies for not getting to this yet, but would prefer to keep it open.

[bruth]

I agree that shadowing the copy built-in is not ideal, so this is a welcome improvement. The same set of variables are still present in the current revision, so a rebase should resolve the conflict and fix the CI.

@dtest11 If you are still willing and able to rebase, please do, otherwise I will open a new PR against head of main.