nats-architecture-and-design
nats-architecture-and-design copied to clipboard
Failed Authentication Opt-out
Overview
Traditionally clients have aborted reconnect reattempts after 2 consecutive authentication errors. https://github.com/nats-io/nats.go/pull/499
In some setups this behavior creates a different problem because a configuration mistake on the server will stop thousands of clients.
Provide a connect option ignoreAuthErrorAbort
that prevents the 2 consecutive errors from aborting the reconnect attempts.
See https://github.com/nats-io/nats.deno/commit/cf2b33cb8a936841e536adbd453bb4755aa6fdb5 - javascript client changes to fix this.
Clients and Tools
- [X] Go @piotrpio https://github.com/nats-io/nats.go/pull/1141
- [x] Java @scottf https://github.com/nats-io/nats.java/pull/1011
- [X] JavaScript
- [x] .Net @scottf
- [ ] C @levb
- [ ] Python @wallyqs
- [ ] Ruby @wallyqs
- [ ] Rust @Jarema @caspervonb
Other Tasks
- [ ] docs.nats.io updated @jnmoyne
- [ ] Update ADR to
Implemented
- [ ] Update client features spreadsheet
Client authors please update with your progress. If you open issues in your own repositories as a result of this request, please link them to this one by pasting the issue URL in a comment or main issue description.
@aricart No urgency, but is this and #171 extending an existing ADR or does a new one need to be created?
@aricart No urgency, but is this and #171 extending an existing ADR or does a new one need to be created?
@bruth there's no ADR - this is just a connect option to prevent the default client behaviour.
Ok thanks, that is what I assumed. I am in the process of evolving some PR templates to help differentiate the kinds of issues that are created in this repo.