k8s icon indicating copy to clipboard operation
k8s copied to clipboard

Question on releases

Open jbury opened this issue 3 years ago • 7 comments

I got a PR merged in a bit ago (https://github.com/nats-io/k8s/pull/394) that should add some functionality to the NATS setup image.

Currently I'm using a setup script that is based on the script found at https://nats-io.github.io/k8s/setup.sh, and it references the NATS setup image at synadia/nats-setup:0.1.6. I'm wondering if/when the PR I merged in above will be available in a pre-built docker image, and whether or not I'll need to update the version I'm pointing to in my setup.sh script to pull that change in. Do I need to wait for a release? Is there a cicd pipeline building that image out for consumption somewhere?

Any guidance on this?

jbury avatar Jan 01 '22 23:01 jbury

So you guys just pushed a new release, and looking at the synadia/nats-setup image on Dockerhub, no updates have been pushed in almost 2 years. Is this image no longer being mantained/updated? Is this just a miss in the automation? Can we get it updated with the latest-and-greatest from the setup dir?

jbury avatar Jan 11 '22 01:01 jbury

@wallyqs It looks like you're the one that actually pushed the last version of that image - any chance you can do it again (or set up automation to do it on release)?

jbury avatar Jan 11 '22 22:01 jbury

@jbury yes hoping to tackle this soon...

wallyqs avatar Jan 11 '22 22:01 wallyqs

@wallyqs Looks like that image is still out of date. Is there anything I can do to help you guys get some automation in place to do a regular-cadence release of that image? Or, alternatively, is the plan to just sunset it altogether in lieu of pure helm deployments?

You mentioned here: https://github.com/nats-io/k8s/issues/409 that you plan to remove some of the non-helm setup cruft, but I don't know if that means this image is going away too.

jbury avatar Aug 13 '22 23:08 jbury

@jbury those scripts were pre-Helm 3 release and so far that approach has been faring better, so now I think we should clean up those setup scripts and only leave the Helm parts in this repo probably...

wallyqs avatar Aug 13 '22 23:08 wallyqs

Sounds good. I'll leave that cleanup to you then? Unsure if there's docs that need updating along with it.

As an aside, I really dislike using helm directly, so I'll probably be pushing some MRs your way to make it more usable via indirect helm invocations :) Feel free to close this issue if you'd like, or keep it open as a reminder to clean up ye olde scripts.

Cheers!

jbury avatar Aug 14 '22 05:08 jbury

Dunno what, if anything, you'll want to do with the image referenced in this issue - but just popping a reminder to deprecate that bad boy too, since it's already out of date as is.

jbury avatar Aug 14 '22 05:08 jbury