graft icon indicating copy to clipboard operation
graft copied to clipboard

Published 20 hours ago • verified publisher icon nats-io

Fixing race conditions

Open rwrz opened this issue 2 years ago • 4 comments

I'm using this library with -race and Go warned me about some possible race conditions. This commit fixes it.

All tests are still working. :1st_place_medal:

rwrz avatar Dec 29 '22 21:12 rwrz

Coverage Status

Coverage: 91.173% (+0.1%) from 91.052% when pulling 68aad8b6b880c77c47b3512b117deb4aaef3d9b1 on rwrz:fix-race into 5f246deca4c2a70efb107df41606867123bd3142 on nats-io:master.

coveralls avatar Dec 29 '22 21:12 coveralls

Need to fix one failure on CI failure.

https://app.travis-ci.com/github/nats-io/graft/jobs/592230016

derekcollison avatar Dec 29 '22 22:12 derekcollison

Seems to be just a download error. Can you retry?

rwrz avatar Dec 31 '22 13:12 rwrz

go 1.16 is complaining about the following.

github.com/nats-io/nats-server/[email protected]/server/events.go:31:2: //go:build comment without // +build comment

I might suggest bumping the Go version in the .travis file to go 1.18 and go 1.19 and see if it clears.

derekcollison avatar Jan 01 '23 03:01 derekcollison