vue-cli-template icon indicating copy to clipboard operation
vue-cli-template copied to clipboard

Fix action bar color according to the theme selected.

Open tralves opened this issue 7 years ago • 3 comments
trafficstars

Fixes #98.

Even if in the future you remove the nativescript-theme-core (replacing with ns-tailwind? ;) ), right now it is pretty confusing. I just lost an embarrassing amount of time because I picked the theme 'forest' and just assumed that the action bar color was coming from the theme...

Anyway, this is a small fix that I think improves the current template.

tralves avatar Oct 11 '18 18:10 tralves

This is something I wanted to do, but haven't gotten around to doing yet. Ideally I'd like to make the theme optional, as for most projects I work on, I don't need it, and there is no easy way to opt-out currently.

What I'm thinking is adding conditions to only add the page and action-bar classes when there is a theme selected. Would you mind working on this, or should I give it a bit more thought and come up with something that should work better?

rigor789 avatar Oct 11 '18 18:10 rigor789

I can do that. But then we also need to add a none option to the theme, right?

tralves avatar Oct 12 '18 17:10 tralves

I can do that. But then we also need to add a none option to the theme, right?

Yes, that would be the plan to be able to select "none" and then no extra classes are added

rigor789 avatar Oct 12 '18 20:10 rigor789