citizen-app icon indicating copy to clipboard operation
citizen-app copied to clipboard
verified publisher icon nation3

Add Dark mode

Open amochuko opened this issue 1 year ago • 4 comments

The PR enable a Dark theme of the web app

Related GitHub Issue

Update related to https://github.com/nation3/citizen-app/issues/292

Screenshots (if appropriate):

How Has This Been Tested?

  • [x] Status checks pass (lint, build, test)
  • [x] Works on Sepolia preview deployment
  • [ ] Works on Mainnet preview deployment

Are There Admin Tasks?

No

amochuko avatar Aug 14 '24 14:08 amochuko

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
citizen-app-mainnet ✅ Ready (Inspect) Visit Preview Aug 20, 2024 5:21am
citizen-app-sepolia ✅ Ready (Inspect) Visit Preview Aug 20, 2024 5:21am

vercel[bot] avatar Aug 14 '24 14:08 vercel[bot]

@amochuko is attempting to deploy a commit to the Nation3 DAO Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Aug 14 '24 14:08 vercel[bot]

WIP with remaining two items:

  1. The logo
  2. Hamburger icon (Nav bar)

Kindly take a look over and let me your thoughts. Thanks

amochuko avatar Aug 14 '24 14:08 amochuko

WIP with remaining two items:

  1. The logo
  2. Hamburger icon (Nav bar)

Kindly take a look over and let me your thoughts. Thanks

I got item 2 done; and created a placeholder for item 1 which I intend to fill with a logo that would fit a dark mode.

amochuko avatar Aug 14 '24 16:08 amochuko

@amochuko When I hover a menu item in light mode, the item's background color changes. Can we keep this functionality in dark mode?

Sure, we can. I'll go rectify it.

amochuko avatar Aug 15 '24 02:08 amochuko

@amochuko When I hover a menu item in light mode, the item's background color changes. Can we keep this functionality in dark mode?

I've made a fix.

amochuko avatar Aug 15 '24 03:08 amochuko

Thank you, @amochuko. Can you also change the alert div at https://citizen-app-mainnet-git-fork-amochuko-dark-mode-nation3dao.vercel.app/lock into dark theme?

aahna-ashina avatar Aug 19 '24 02:08 aahna-ashina

Thank you, @amochuko. Can you also change the alert div at https://citizen-app-mainnet-git-fork-amochuko-dark-mode-nation3dao.vercel.app/lock into dark theme?

I've updated the alert on Dark mode and ensured keeping it still noticeable.

amochuko avatar Aug 19 '24 06:08 amochuko

I've updated the alert on Dark mode and ensured keeping it still noticeable.

@amochuko I don't see any dark theme added with your latest commit. Am I looking at the correct preview URL? - https://citizen-app-mainnet-git-fork-amochuko-dark-mode-nation3dao.vercel.app/

aahna-ashina avatar Aug 19 '24 07:08 aahna-ashina

I've updated the alert on Dark mode and ensured keeping it still noticeable.

@amochuko I don't see any dark theme added with your latest commit. Am I looking at the correct preview URL? - https://citizen-app-mainnet-git-fork-amochuko-dark-mode-nation3dao.vercel.app/

I wanted the alert message to still remain noticeable in a Dark mode so I used dark:bg-slate-200 (mild shade); but I've replaced with dark:bg-slate-300

amochuko avatar Aug 19 '24 08:08 amochuko