nathom
[BUG] Configured lossy_bitrate not used
Describe the bug
I'm having the issue of ffmpeg not been given the correct bitrate flag for song conversion. Upon reading through the code, it seems to me that the lossy_bitrate field in the config file is never used, thus the conversion engine using its default value (-q:a 0)
Thanks :)
Command Used
rip --quality 1 --folder . url <url>
Debug Traceback
Not applicable
Config File
# Convert tracks to a codec after downloading them.
[conversion]
enabled = true
# FLAC, ALAC, OPUS, MP3, VORBIS, or AAC
codec = "MP3"
# In Hz. Tracks are downsampled if their sampling rate is greater than this.
# Value of 48000 is recommended to maximize quality and minimize space
sampling_rate = 48000
# Only 16 and 24 are available. It is only applied when the bit depth is higher
# than this value.
bit_depth = 24
# Only applicable for lossy codecs
lossy_bitrate = 320
Operating System
Linux
streamrip version
2.0.5
Screenshots and recordings
No response
Additional context
No response
Working on it, if you specify quality, it "override" config convert option ans take the raw file quality from service But when you specify a codec or you enable convertion in config, streamrip don't convert the file, it's strange
Well, I did get streamrip to convert the files to mp3, however the target bitrate is incorrect. In fact, the issue lies in the bitrate configuration never been read and the default one being passed to ffmpeg.