streamrip icon indicating copy to clipboard operation
streamrip copied to clipboard

Update album.py to accept subfolders in config variable folder_format

Open cloud74pebble opened this issue 1 year ago • 2 comments

Correct handling of subfolders in config variable "folder_format"

e.g.: [filepaths] folder_format = "{albumartist}/{title} ({year})"

old method didn't allow creating subfolders by stripping "" or "/"

cloud74pebble avatar Aug 26 '24 09:08 cloud74pebble

I think this might cause unexpected behavior if there is a / in any metadata.

nathom avatar Sep 01 '24 17:09 nathom

It doesn't affect any metadata. It is just the storage-path in the filesystem.

with last release it was possible to sort the output to folders: e.g. Albumartist/Albumtitle or Albumartist/Year/Albumtitle

Using the current dev-branch it wasn't possible anymore. This small patch fixed it.

cloud74pebble avatar Sep 02 '24 19:09 cloud74pebble

Bump

Delivator avatar Dec 10 '24 17:12 Delivator

This works for me too

nzoschke avatar Dec 21 '24 20:12 nzoschke

I think this might cause unexpected behavior if there is a / in any metadata.

This looks to be handled properly.

Metadata albumartist, albumcomposer, title all pass through clean_filename before being passed as the format kwargs. So if that metadata has / it is stripped then used as subpaths for the folder_format when it contains /.

nzoschke avatar Dec 21 '24 20:12 nzoschke