looper
looper copied to clipboard
nathany
Adding support for testing with appengine classic
This adds support to use the goapp binary instead of the go binary to run the tests. This can't be implemented with #26 although I support that initiative too.
More flags are frowned upon sometimes I know for sacrificing simplicity, but many of my projects use appengine classic which still requires the goapp tool to pull in appengine classic code (modified $GOROOT)
What do you think of using some sort of detection rather than a flag? Maybe something based on app.yaml in the working directory?
app.yaml is just the default -- especially when you start using modules, the yaml file will be named something else. Also detecting on app.yaml would then include other directories that have that file but aren't actually using appengine.
I guess what I'm saying is, I think a flag is the easiest explicit method. Feel free not to accept the PR though; it's not a big deal.
That makes sense. I don't know if flags will be the long-term solution, but it works for now.
I should give this a quick test before merging. Thanks.