`.on("ready", fn)` is removed in jQuery 3

Open mtsmfm opened this issue 9 years ago • 3 comments

https://jquery.com/upgrade-guide/3.0/#breaking-change-on-quot-ready-quot-fn-removed

Aug 10 '16 08:08 mtsmfm

Thanks. Damn, the code looked nicer before, being able to combine both events 😢

Aug 10 '16 10:08 nathanvda

:cry:

BTW, it seems that tests will fail even master branch. Are anyone trying to fix tests?

Aug 10 '16 10:08 mtsmfm

Re tests: I'll have a look later today or tomorrow. The tests passed on my last release, so probably something changed at travis' side.

We should also prepare for rails 5/turbolinks 5 where the event was renamed from page:load to turbolinks:load. Hopefully I can keep it backwards compatible easy enough (because not sure, but the turbolinks:load also seems to be triggered on ready?).

Aug 10 '16 11:08 nathanvda