Nathan Boyer

Results 74 comments of Nathan Boyer

I really have no clue. I haven't done any profiling or benchmarking on the code. It is basically a brute force computation that used to be fast enough. I can...

Thank you for the review. I believe I addressed all your comments, but I left it to you to determine if satisfactory and "Resolve" them.

> documenter fails - have you checked why? I've never used Documenter.jl before. I just tried to edit the `make.jl` and `index.md` files by copying what was already there.

I don't know why the cross references aren't working. It looks to me like I am doing it right. https://documenter.juliadocs.org/dev/man/syntax/#@ref-link

Need to see if documenter tests pass this time. There is also a subsection I would like at the end on performance, but I am hoping someone else can write...

I think I fixed my errors, but I am still getting some errors below which seem unrelated to me. I get this error on main with `julia --project make.jl`: ```...

I thought that I already was in sync from this: https://github.com/JuliaData/DataFrames.jl/pull/3360/commits/7614fc3b61f673b7def35a1d0e55dc22e061427c but I found another button to sync on my repository page which fixed the `strict` line. I am still...

That is a bummer that `@with` has to change. FWIW, I like the `@withdf` name better than `@attach`. > `@withdf` is awkward because people will write `@withdf df begin ...`...

Also, it looks like the name of the command changed from "Run: Start Without Debugging" to "Debug: Start Without Debugging". ![image](https://github.com/julia-vscode/docs/assets/65452054/7c4c10dc-166a-47d5-81ff-f17ad7111d26)