Nathan Perkins
Nathan Perkins
The reasoning for this behavior is documented here: ``` func terminalHookOverride(defaultHook, override zapcore.CheckWriteHook) zapcore.CheckWriteHook { // A nil or WriteThenNoop hook will lead to continued execution after // a Panic...
Thanks for bringing up this discussion! We were having problems with backed up workqueues in some of our controllers and disabling the client-side rate limiter in favor of APF took...
We are shifting these responsibilities away from my team so we don't need this anymore.
Thanks! Looking forward to this feature and was wondering how we would enable it in controller-runtime. Automatic enablement would be really cool :)
Just to confirm my understanding: - Controller Reconcile() uses the cache and will have APIStreaming enabled by default in controller-runtime v0.20. - Calling client.List() on a live client (without caches)...
We are shifting these responsibilities away from my team so we don't need this anymore.
Out for review: #44
There is a tool which can assist with checking for incompatible APIs and suggesting new major version bump. https://pkg.go.dev/golang.org/x/exp/cmd/gorelease This could be added to CI to warn about breaking changes...
Thank you for the response! :) >The various k8s.io dependencies we pull in deliberately decided to stay on 0.X versions and we are doing the same. We usually bump them...
This issue is a lot more serious with the webhook.Validator change in 0.15. Our module using controller-runtime 0.15 can't import APIs which use 0.14 or before which have implemented webhook.Validator...