dfs-datastores icon indicating copy to clipboard operation
dfs-datastores copied to clipboard

Snapshot doesn't allow injection of a FileSystem to use for the snapshot destination

Open dkincaid opened this issue 11 years ago • 2 comments

The Pail.create() methods allow a FileSystem to be used in the creation of the pail. However, when creating a snapshot of a pail the only option is to include the FileSystem in the path string that is passed in for the destination. In order to keep consistency, all the methods that create a new Pail at a new path should allow a FileSystem to be given separately from the path.

dkincaid avatar May 21 '13 02:05 dkincaid

I'll take a look. Again, a PR would be awesome :)

sorenmacbeth avatar May 21 '13 02:05 sorenmacbeth

I'm not exactly sure what I did, but both commits for this issue and 30 ended up on a single PR. Someday I'll figure out the proper way to do PR's on Github. Hopefully it's not too much work to tease them apart (if you even need to).

dkincaid avatar May 21 '13 03:05 dkincaid