node-poweredup
node-poweredup copied to clipboard
nathankellenicki
Re-connection to already known hubs
This pull requests improves the Web Bluetooth support. The scan method scans for advertisements of hubs that have been connected before. The old scan method that caused a popup in the browser has been renamed to requestDevice.
I've tested with Chrome 87. The following flags are required:
- chrome://flags/#enable-experimental-web-platform-features
- chrome://flags/#enable-web-bluetooth-new-permissions-backend
There are still issues that the LED color does not change in the sample application, but I had the same issue with the original code.
That is a nice improvement. Instead of changing the behavior of the scan method (which would break backward compatibility), do you think it could be a parameter of the scan method ?
Instead of changing the behavior of the scan method (which would break backward compatibility), do you think it could be a parameter of the scan method ?
The reason why I renamed the scan method is that the new scan/stop methods act very similar to the Node implementation so I thought they should use the same names. The requestDevice method has no equivalent in Node so I thought it should have a new name.
As scan and requestDevice do different things it is cleaner to have separate methods. But I'm fine with a parameter if backward compatibility must be preserved.
Instead of changing the behavior of the scan method (which would break backward compatibility), do you think it could be a parameter of the scan method ?
The reason why I renamed the scan method is that the new scan/stop methods act very similar to the Node implementation so I thought they should use the same names. The requestDevice method has no equivalent in Node so I thought it should have a new name.
Seems legit.
This lib uses the term "Device" to refer to items connected to hubs (motors, sensors...), I think requestDevice could be confusing, maybe requestHub could be more accurate.
@pwimmer I'm fine with breaking changes when good rationale is presented, and this is good rationale. :) Synchronicity between the Node.js and Web Bluetooth API is certainly a plus to reduce the amount of mental hoops would need to jump over when working between the two.
@aileo 's suggestion for requestHub over requestDevice is a good one to maintain naming conventions with the rest of the lib.
This is a great additional piece of functionality, many thanks for the contribution! My main concern is the necessity for end users to enable experimental features in the browser - one of the tenets I tried to follow is to make it so that the lib could just be published to a website which end users could visit with no further barriers. Do you have additional information on when these features may land proper? A link to some docs or discussions perhaps?
Thanks, and happy holidays to both!
@pwimmer I got around to testing this PR properly tonight. Unfortunately it looks like these features still haven't landed as they need to be turned on in Chrome flags.
In addition, I wasn't able to get this reliably working. After pairing, it wouldn't automatically reconnect to any previously paired hubs until I opened the pairing dialog again, at which point it would automatically connect, even without selecting the device and pairing. It seems unfortunately there are still some bugs in the implementation.
In addition, I wasn't able to get this reliably working. After pairing, it wouldn't automatically reconnect to any previously paired hubs until I opened the pairing dialog again, at which point it would automatically connect, even without selecting the device and pairing. It seems unfortunately there are still some bugs in the implementation.
Automatic reconnection requires a https server. It doesn't work with http.