achievements
achievements copied to clipboard
nathanielop
Some improvements and fixes
Hi, I saw your code and I am interested in it, but it contains some errors and I just fixed some of those. Can you take a look at it? https://github.com/MasterPi-2124/achievements
The repo created in bin/setup is private, so I think github won't count that to the achievements. Instead, I make commits and prs straight into the main repo.
I saw you dropped the timeouts between pullshark PRs to 20s, does this not conflict with the github rate limiter? I spitballed when I initially set it to 60s, so if you end up getting rate limited make sure to bump the timeout up.
Yeah I took a quick peek and looks pretty good, if you want to open a PR against this repo I can merge it tonight.
As far as the private repository goes, private repository achievements count so long as you have the "Show private contributions setting enabled on your github account", as referenced here, although I'm indifferent as to whether or not it just commits against the main repo or a new one. Given, committing against the main repo definitely simplifies the setup process.
Thanks for ironing out the setup stuff, it was the last hurdle that this repo really had before being usable! =)
After merge I'll go in and update the README to reflect the new flow (prerequisites-wise).
hi, 20s is set accidentally :)). I will change that back to 40 50s. About our code, I think that both you and I are testing to make it work, for example in P-E file I see that we have different approaches. I think we just keep testing ourselves before marking as done and then merging. For now I think we can keep the discussion here, or go to https://github.com/Schweinepriester/github-profile-achievements and discuss with @Schweinepriester
Works for me either way, while I haven't pushed the changes up to this I intend to make similar changes to pair extraordinaire after testing of my initial approach proved that my assumption it was based purely on commits was wrong. However, I agree it's probably best to go at it separately and then merge when we have the optimal solution. We can continue discussion at the linked discussion.
Stale, although I've incorporated improvements made from your version into mine where possible while avoiding code dupe directly. I'll add a link to your repo as an improved one to the readme for future reference.