pathvector icon indicating copy to clipboard operation
pathvector copied to clipboard

[Request] Restart Command

Open rapdodge opened this issue 1 year ago • 5 comments

Hello there, Is that possible to having command like pathvector restart xxx?

Why I'm requesting this? Because we already have pathvector status which is pretty print from birdc show protocol

With pathvector restart I was hoping to make restarting session that printed on pathvector status will be easier, rather than run birdc show protocol, searching the session name, and then run birdc restart xxx

Thanks!

rapdodge avatar Feb 12 '24 01:02 rapdodge

Hello rapdodge,

Would something like this help you out:

  • "pathvector protocol --restart [protocol]"
  • "pathvector protocol --reload [protocol]"
  • "pathvector protocol --enable [protocol]"
  • "pathvector protocol --disable [protocol]"

I would be happy (when I have a bit of time) to make this and send it in for a pull request.

Dennis-de-Houx avatar Apr 17 '24 15:04 Dennis-de-Houx

Hello rapdodge,

Would something like this help you out:

  • "pathvector protocol --restart [protocol]"
  • "pathvector protocol --reload [protocol]"
  • "pathvector protocol --enable [protocol]"
  • "pathvector protocol --disable [protocol]"

I would be happy (when I have a bit of time) to make this and send it in for a pull request.

Hello Dennis,

That would be great idea ☺️ But, I think without -- is better (?)

So, it would be like

pathvector protocol (type (restart, enable, disable, etc)) [protocol]

Thanks,

rapdodge avatar Apr 17 '24 15:04 rapdodge

Hello rapdodge,

I have made a beta version, will do some debugging later on the day/night and then do a pull request (PR).

I have the following for command line:

pathvector protocol <(r)estart|re(l)oad|(e)nable|(d)isable> <protocol name> -m <message>

Message is only used for custom message on enable/disable with a default disable message "Protocol manually disabled by pathvector"

Example

pathvector protocol disable TRANSIT1_V6 --message "Cable is damaged"

and the shorthand version

pathvector p d TRANSIT1_V6 -m "Cable is damaged"

Dennis-de-Houx avatar Apr 18 '24 03:04 Dennis-de-Houx

Hello rapdodge,

I have made a beta version, will do some debugging later on the day/night and then do a pull request (PR).

I have the following for command line:

pathvector protocol <(r)estart|re(l)oad|(e)nable|(d)isable> <protocol name> -m <message>

Message is only used for custom message on enable/disable with a default disable message "Protocol manually disabled by pathvector"

Example

pathvector protocol disable TRANSIT1_V6 --message "Cable is damaged"

and the shorthand version

pathvector p d TRANSIT1_V6 -m "Cable is damaged"

That's nice! Looking forward into it 😁

rapdodge avatar Apr 19 '24 01:04 rapdodge

Pull Request has been made

Dennis-de-Houx avatar Apr 19 '24 01:04 Dennis-de-Houx