tslint-stencil icon indicating copy to clipboard operation
tslint-stencil copied to clipboard

Published 20 hours ago • verified publisher icon natemoo-re

lifeCycle hooks are incomplete

Open chrisweight opened this issue 6 years ago • 4 comments

StencilJS has a number of lifecycle hooks documented and available that are not a part of this lint ruleset.

Ref: https://stenciljs.com/docs/component-lifecycle

chrisweight avatar Jun 20 '19 10:06 chrisweight

Thanks for opening this!

I haven't had much time to up with the changes for stencil@one, but I will do my best to fix this soon.

natemoo-re avatar Jun 21 '19 21:06 natemoo-re

Looks like these ones are missing:

  • connectedCallback()
  • disconnectedCallback()
  • componentWillRender()
  • componentDidRender()

Will updating these constants be sufficient or is there more work under the hood to implement a fix?

claviska avatar Oct 08 '19 14:10 claviska

There is a new one componentShouldUpdate(). https://github.com/ionic-team/stencil/pull/1876

pixelbucket-dev avatar Oct 17 '19 15:10 pixelbucket-dev

@natemoo-re Please find the PR for this https://github.com/natemoo-re/tslint-stencil/pull/17

LalitKushwah avatar Jul 02 '20 10:07 LalitKushwah