astro-icon icon indicating copy to clipboard operation
astro-icon copied to clipboard

feat: pass props to custom resolver

Open germanz opened this issue 2 years ago • 6 comments

The following PR passes Icon properties down to custom resolver in order to allow building custom asset URLs that depend not only on icon name, but also size.

germanz avatar Jul 06 '22 09:07 germanz

🦋 Changeset detected

Latest commit: 73cb90e1628f0704ebc8b9406bac4a1516fad5b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
astro-icon Minor
www Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jul 06 '22 09:07 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
api-astroicon ✅ Ready (Inspect) Visit Preview Jul 19, 2022 at 4:27PM (UTC)
astroicon ✅ Ready (Inspect) Visit Preview Jul 19, 2022 at 4:27PM (UTC)

vercel[bot] avatar Jul 06 '22 09:07 vercel[bot]

Hi @natemoo-re, please take a look when you have time.

germanz avatar Jul 06 '22 09:07 germanz

Thanks for adding a changeset. Will make sure to add next time ;). Is there anything else needed from my side, or you'll merge?

germanz avatar Jul 19 '22 19:07 germanz

@natemoo-re, can you merge this please 🙏 ?

ghost avatar Aug 05 '22 15:08 ghost

@natemoo-re Can we have this released please? 🙏

edv-ns avatar Sep 12 '22 11:09 edv-ns