astro-icon icon indicating copy to clipboard operation
astro-icon copied to clipboard

Comments in local SVG files are removed regardless of configuration

Open sandrofigo opened this issue 6 months ago • 1 comments

What version of astro-icon are you using?

v1.0.1

Astro Info

Astro                    v4.0.8
Node                     v18.18.0
System                   Linux (x64)
Package Manager          npm
Output                   static
Adapter                  none
Integrations             astro-icon

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

When using a local SVG file (containing comments <!-- -->) from the icons folder, the rendered HTML does not contain the comments, although the SVGO plugin removeComments is disabled in the config file:

// astro.config.mjs
import { defineConfig } from 'astro/config';

import icon from 'astro-icon';

// https://astro.build/config
export default defineConfig({
  integrations: [
    icon({
      svgoOptions: {
        multipass: true,
        plugins: [
          {
            name: 'preset-default',
            params: {
              overrides: {
                // customize default plugin options
                inlineStyles: {
                  onlyMatchedOnce: false,
                },

                // or disable plugins
                removeDoctype: false,

                // FOR BUG REPORT:
                removeComments: false,
              },
            },
          },
        ],
      },
    }),
  ],
});

What's the expected result?

Comments should be preserved in the final output, since some icons (e.g. Font Awesome) require the CC BY 4.0 license notice (https://fontawesome.com/license/free)

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-aqxtyy?file=astro.config.mjs

sandrofigo avatar Dec 31 '23 13:12 sandrofigo