Nate McMaster

Results 130 comments of Nate McMaster

Thanks @andywu188. I've merged your PR and uploaded https://www.nuget.org/packages/LettuceEncrypt/1.3.2-beta.292 Can you help me test and validate this fix works?

Thank you for the fix and testing!

I'd welcome a PR to fix this.

To be clear, SkipIfNotDockerAttribute is meant to skip tests when not running *inside* a container. It's not meant to skip tests running on a host if Docker is not installed....

I'm fine adding a new dependency if it's the only good way to detect if a process is running inside a Windows container

Pull requests accepted :) currently busy taking care of my newborn so sorry for delayed responses.

1. Via NuGet packages on a per-project basis 2. Via NuGet packages with custom targets 3. Via the system's PATH I would recommend 2 for sure. 1 is more effort...

Ok. I'll make a PR for item 2. Item 1 might take more effort so I'l do that separately.

There is enough compatible API that I don't think this tool will run on .NET Core 1.x without major rewrites. I took a wack at compiling ILMerge for .NET Core...

@Fabi I'm not actually sure what either of those APIs do. I'd have to take a closer look at what this code is doing. Also, some of these more-obscure interop...