LettuceEncrypt icon indicating copy to clipboard operation
LettuceEncrypt copied to clipboard

Fix fallback to default certificate configuration

Open Tom-V opened this issue 2 years ago • 1 comments

This fixes #122 Requests without SNI fail with: "The server mode SSL must use a certificate with the associated private key."

Basically when setting a ServerCertificateSelector it overrides the default behavior, returning null will give an error instead of falling back to the configuration. This change only sets the ServerCertificateSelector whenever domains are configured. To do this however I had to break the API.

Tom-V avatar Oct 11 '23 08:10 Tom-V

I would prefer to avoid breaking changes if we can. Does this approach work instead? https://github.com/natemcmaster/LettuceEncrypt/pull/290

natemcmaster avatar Dec 31 '23 22:12 natemcmaster

I've released https://github.com/natemcmaster/LettuceEncrypt/pull/290 to nuget as version 1.3.1. Please let me know if that works for you.

natemcmaster avatar Mar 30 '24 04:03 natemcmaster