DotNetCorePlugins icon indicating copy to clipboard operation
DotNetCorePlugins copied to clipboard

add JsonNet13, bump dependencies, fix naming

Open Misiu opened this issue 1 year ago • 1 comments

I've removed three projects (JsonNet10, JsonNet11, JsonNet9) and added a new project (JsonNet13). The runtimeOptions property in the RuntimeConfig class was marked as obsolete and replaced with RuntimeOptions. The version of System.Data.SqlClient in SqlClientApp.csproj was updated from 4.8.3 to 4.8.6.

This is my first contribution, before starting to use the project in my POC. I plan to clean the naming and add comments to public classes that currently miss them.

My old app (Autofac based) uses expressions and three lifetime scopes, so hopefully I'll be able to replace Autofac with your library and simplify the logic as much as possible.

Misiu avatar Apr 02 '24 10:04 Misiu

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 53.73%. Comparing base (e1e4567) to head (10283fe).

:exclamation: Current head 10283fe differs from pull request most recent head 9253a06. Consider uploading reports for the commit 9253a06 to get more accurate results

Files Patch % Lines
src/Plugins/Loader/RuntimeConfigExtensions.cs 0.00% 5 Missing :warning:
src/Plugins/Internal/RuntimeConfig.cs 0.00% 2 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##               v2     #290       +/-   ##
===========================================
- Coverage   66.80%   53.73%   -13.07%     
===========================================
  Files          14       14               
  Lines         494      495        +1     
  Branches        0      126      +126     
===========================================
- Hits          330      266       -64     
- Misses        164      185       +21     
- Partials        0       44       +44     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 07 '24 03:04 codecov[bot]