Nate Matykiewicz
Nate Matykiewicz
FYI, the buildkite failure is unrelated: ``` Failure: ActiveRecord::ConnectionAdapters::ReaperTest#test_connection_pool_starts_reaper_in_fork [test/cases/reaper_test.rb:161]: Expected # to be success?. ```
I just fixed the merge conflict on the changelog
@seanpdoyle I was thinking the exact same thing, but figured maintainers would want 2 PRs. I'd gladly add it to this one, though.
@seanpdoyle I was thinking the exact same thing, but figured maintainers would want 2 PRs. I'd gladly add it to this one, though.
@flavorjones I rebased to main again @rafaelfranca I removed support for String/Symbol and made it only support an Array of Strings and/or Symbols. Is that what you were looking for?
My primary use-case is for a JSON API. I do not control the UI, so I can't make it impossible for someone to try to insert wrong values. I don't...
That's not quite the same. If the association is non-optional, a nil "type" will provide two validation errors on one field, which in my opinion is silly. Also, I find...
As @seanpdoyle pointed out (and I was also thinking before opening the PR), it could make a lot of sense to make delegated types pass the `types` option to the...
You're right though. I can and most certainly do manually add a validation. But I think that it's a nice developer experience improvement for the polymorphic association to be in...
I'll work on adding this to delegated types, too. Thanks for the review!