slurm-drmaa icon indicating copy to clipboard operation
slurm-drmaa copied to clipboard

Published 20 hours ago • verified publisher icon natefoo

Refs #31: Single quotes in the expanded args should be escaped

Open stmlange opened this issue 6 years ago • 8 comments

Fixes https://github.com/natefoo/slurm-drmaa/issues/31

stmlange avatar Sep 10 '19 13:09 stmlange

Thanks @stmlange. I think you should be able to use the existing fsd_replace function for this.

natefoo avatar Jan 23 '20 16:01 natefoo

Hi, sorry for the late reply. I have incorporated your suggestion and will some additional testing....I will follow up once completed.

stmlange avatar Feb 27 '20 10:02 stmlange

Sorry for the clutter here, but I noticed that when using the existing fsd_replace function I don't need to call fsd_free -- otherwise this results in a double-free. The update I pushed caused all the linkage here :/

stmlange avatar Feb 27 '20 15:02 stmlange

Mhh after some extensive testing it seems that the fsd_replace-function causes an infinity loop.

stmlange avatar Mar 12 '20 16:03 stmlange

Since you seem active again: Is there anything I could do to get this integrated?

I should note that the previous statement still seems to be accurate: In my custom version using the fsd_replace-function seems to cause an infinity loop. Hence I'm using the proposed alternative: https://github.com/stmlange/slurm-drmaa/commit/f896f5c272004d93dfc2684f42ed313b8dca00c7

stmlange avatar Sep 18 '23 18:09 stmlange

Is there anything I could do to get this integrated (e.g. run further testing or any other experiments)?

stmlange avatar Oct 04 '23 06:10 stmlange

@natefoo Is there anything I could do to get this integrated (e.g. run further testing or any other experiments)?

stmlange avatar Sep 20 '24 08:09 stmlange

Sorry, not sure how I missed all these notifications - I will take a look at this.

natefoo avatar Sep 20 '24 19:09 natefoo