pie icon indicating copy to clipboard operation
pie copied to clipboard

Confusing on python example

Open zeroZshadow opened this issue 9 years ago • 2 comments

Im a little confused about the python example.

Why not embed *rpc.Client ? Should Add not be (p *plug) instead of (p plug) ? No error checking on StartProviderCoded, which is a bad example to give.

Especially the last note, considering the example does not run on my windows machine: Create error: fork/exec ./plugin.py %i is not a valid Win32 application.

zeroZshadow avatar Nov 25 '15 23:11 zeroZshadow

Ahh, thanks for bringing this up. That code was contributed by someone else. I'll go review it and see what I can do to make it clearer and better.

natefinch avatar Nov 30 '15 02:11 natefinch

"Should Add not be (p *plug) instead of (p plug) ?" Sorry, I'm totally wrong here. This part is fine the way it is.

zeroZshadow avatar Nov 30 '15 07:11 zeroZshadow