lumberjack icon indicating copy to clipboard operation
lumberjack copied to clipboard

V3.0

Open thalesfsp opened this issue 4 years ago • 5 comments

thalesfsp avatar Jun 29 '21 07:06 thalesfsp

Hey @natefinch any idea when the V3.0 will be released ?

fahedouch avatar Apr 22 '22 20:04 fahedouch

@fahedouch Wow, I thought it got merged at some point. It's almost 1 year old now!

thalesfsp avatar Apr 28 '22 00:04 thalesfsp

Ug, sorry. I'll take a look at this in a bit.

natefinch avatar Apr 28 '22 00:04 natefinch

@natefinch perfect! can have this https://github.com/natefinch/lumberjack/pull/158 in V3.0 plz . We need it in nerdctl https://github.com/containerd/nerdctl/pull/959/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R174

fahedouch avatar Apr 28 '22 16:04 fahedouch

So, I made a v3 branch, mostly because reviewing 1000 lines of someone else's code is really hard. It's up to parity with v2 right now and all the tests pass, but I don't want to cut a non-alpha release just yet, so I have some time to make sure the API is good before I lock it down.

natefinch avatar May 12 '22 18:05 natefinch