Nate Bosch

Results 719 comments of Nate Bosch

I dug a bit deeper and remembered the point at which this became more complex enough for me to drop it last time I looked. We should also fix the...

I had started thinking about the design here and we decided to hold off on this PR, but then I never finalized a plan. I had some work towards a...

@mraleph - can you suggest any way to get more information about the failure? @hpp0hpp - do you have a stack trace? Does it point to anywhere helpful?

Should this get merged?

Yeah the current behavior is magic and confusing - the hidden interactions with error zones does cause problems. https://github.com/dart-lang/shelf/issues/2#issuecomment-742081585 My preference is to remove anything related to error zones in...

@kevmoo I wonder if this is something we to try to tackle quickly in case it's easier to do with a breaking change. Do you have any thoughts on what...

My goal is to be able to use `shelf_io` without risk of writing to `stderr`. I don't think that is feasible today because if a request comes in that can't...

> Could we just have an optional function param all the way down for `logTopLevelError`? Non-breaking! It looks feasible. I almost wonder if we should drop the behavior around error...

@jakemac53 @kevmoo and I chatted about this. Our biggest concern was that the removal of hidden magic behavior, is also hidden. We don't like that there would be a breaking...

@kevmoo - I think at some point you had mentioned wanting to have access to the `Request` in the error handler. I think we could do that if we use...