Nate Bosch

Results 719 comments of Nate Bosch

I'm surprised that we're able to subvert the asynchrony of `await` on any platform... @lrhn - were you aware of this behavior?

I'm not sure if it is feasible for us to handle this automatically. We can't tell if a `refer('List')` is intended to refer to `dart:core`, or something local to the...

Thanks! I think an option to keep prefixes for `dart:core` makes sense.

> We could deal with that by adding an option on `DartEmitter`, like `prefixCore` or something. SGTM. > assuming it is imported without a prefix. We could either try to...

Is alpha sorting the only thing we'd need or should it be custom? If it's custom I think we will need to be careful that sorting only happens _within_ a...

Is the performance differential with trailing commas new? cc @munificent @srawlins - Is there any reason not to make this the default and only option?

I'll need to add some tests if we decide to go forward with this. I wanted to get some feedback on the overall feature first.

> I'd rather something like that than having a specific option name baked into the class. That was my first thought too. In the end there are a few reasons...

> Sorry, I didn't follow this. I think there's a word or two missing. Yeah this was unclear - I was starting with the assumption that if we added an...

A strong argument in favor of making it a separate top level import is that it will be non-breaking that way. If we were to suddenly introduce these extensions from...