Nate Bosch

Results 719 comments of Nate Bosch

> We could just make it two builders wrapped up under the one though (add a builder factory). Then the options would get plumbed through correctly as is. 👍 >...

> But if you are iterating on them then dart2js is going to re-run anyways Not for the tests you haven't touched, but that's only a problem until we're able...

@jakemac53 - should we do this while we're bumping to 2.0?

The build extensions in `build.yaml` only impact builder ordering today. We use the outputs listed in `build.yaml`, along with `requiredInputs` config to order builders which read certain files after the...

We might run in to problems with https://github.com/dart-lang/sdk/issues/35292

It's always been the case that a `src` import could cause you to bring in extra code, including unsupported code...

> also if any of its transitively imported modules are incompatible. That definitely makes this more tricky - at the time we're doing this level of merging we don't necessarily...

LGTM. Do we already have a way that written assets are communicated through to the `AssetReader`, or are we going through the files system always today? I think we should...

We'll hopefully have a migration plan or at least a design for a replacement before dropping it here so no rush for now.

do you mean building only that output? Definitely on our radar but we don't have a concrete plan yet.